fix: update SQL expressions in console login and MFA trend charts#23
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Superset chart SQL expressions for CloudTrail console login and MFA trend visualizations to use hoisted JSON columns (response_elements, additional_event_data) and a more specific ConsoleLogin event filter, aligning dashboard queries with the ingester’s enriched schema.
Changes:
- Switched ConsoleLogin success/failure extraction from
raw_eventtoresponse_elements. - Switched MFAUsed extraction from
raw_eventtoadditional_event_data. - Updated the documented/example SQL filter to
event_source = 'signin.amazonaws.com' AND event_name = 'ConsoleLogin'.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| dashboard/assets/cloudtrail_default/charts/mfa_less_login_trend.yaml | Updates MFAUsed extraction to use additional_event_data and refreshes the example SQL. |
| dashboard/assets/cloudtrail_default/charts/console_login_activity.yaml | Updates ConsoleLogin and MFAUsed extraction to use response_elements / additional_event_data and refreshes the example SQL filter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.