feat: add performance logging for ingestion phases and GeoIP lookups#24
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds optional ingestion performance instrumentation to the Rust ingester so operators can see where time is spent (discovery, dedup-map load, parsing, insertion, GeoIP, batch marking) and estimate throughput.
Changes:
- Add
--perf-logflag toingester ingestand print a perf breakdown to stderr on completion. - Track per-phase timings in
IngestStatsvia a newPhaseTimingsstruct. - Time GeoIP lookups during insertion and surface that timing to the ingestion pipeline.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
ingester/src/main.rs |
Adds --perf-log CLI flag and prints perf breakdown/throughput when enabled. |
ingester/src/ingest.rs |
Introduces PhaseTimings and instruments discovery/dedup/parse/recv-wait/insert/batch-mark. |
ingester/src/db.rs |
Times GeoIP lookups during inserts and returns (rows_inserted, geoip_ns) from insert_events_with_geo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed #14