chore: update Dockerfile and CI configuration to use --uploaded-prior-to P30D for pip installs#27
Merged
Conversation
…-to P30D for pip installs
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens container/CI dependency installation by adding additional build configuration for Superset helper services and introducing an “only accept packages older than N days” constraint for Python installs.
Changes:
- Add
build:(with CA cert build arg passthrough) tosuperset-initandsuperset-resyncin Docker Compose. - Add
--uploaded-prior-to P30Dto pip installs in Dockerfiles and CI, and pinduckdb-enginefor the Superset image. - Extend frontend
.npmrcwithmin-release-age=7.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| docker/docker-compose.yml | Builds superset-init/superset-resync with the same CA-cert build args as the main Superset service. |
| dashboard/Dockerfile | Pins duckdb-engine to 0.14.0 for Superset’s uv-managed venv. |
| config_viz/frontend/.npmrc | Adds min-release-age=7 to the npm configuration. |
| config_viz/Dockerfile | Adds --uploaded-prior-to P30D to backend dependency installation during image build. |
| agent/Dockerfile | Adds --uploaded-prior-to P30D to dependency installation during image build. |
| .github/workflows/ci.yml | Adds --uploaded-prior-to P30D to pip installs in CI steps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.