Repository navigation
Remove agent-release.json and limit release builds to version tags - #438
Merged
Merged
Conversation
- Limited the `release.yml` tag filter to version tags such as `1.2.0`, `1.2.0-beta.1` and `v1.2.0`. `*.*.*` also matched `legacy-1.2.6`, so publishing that migration draft started a release run that failed at "Require a version tag". - Removed the `agent-release.json` manifest. MeshCentral verifies default downloads against the SHA384 pinned in its own `agents/agent-defaults.json` and imports against GitHub's SHA256 asset digest, so the manifest went stale whenever a draft file was signed or replaced. - Replaced the `manifest` mode of `agent-release.js` with `check`, which only verifies that the build produced exactly the files in `release-files.json`. - Read the migration tag from `release-migration.json` and pointed the migration release notes at it for source paths and checksums. - Updated `docs/releases.md`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In this pull request, the following changes are made:
.github/workflows/release.yml: the*.*.*tag filter also matchedlegacy-1.2.6. Publishing that migration draft creates its tag, so Agent Release started and failed at "Require a version tag". The filter now only matches version tags such as1.2.0,1.2.0-beta.1andv1.2.0..github/scripts/agent-release.js,release.yml,release-migration.yml: removedagent-release.json. MeshCentral never reads it; default downloads are verified against the SHA384 pinned in itsagents/agent-defaults.jsonand imports against GitHub's SHA256 asset digest. A manifest written at draft creation only went stale when a draft file was signed or replaced.checkstill verifies that the build produced exactlyrelease-files.json.docs/releases.md: updated to match.Relates to Add tagged agent releases and bundled binary migration #426
Relates to Agent build management MeshCentral#8177
Please follow this checklist to avoid unnecessary back and forth (click to expand)
I understand that I am responsible for and able to explain every line of code I submit.
the impact on platforms and architectures I could not test.
modules/, I re-embedded them so the compiled-in copies inmicroscript/ILibDuktape_Polyfills.cmatch (the agent runs the embedded copies, not the files on disk)..mshoptions table in readme.md.Testing
checkpasses for the 15 files inrelease-files.jsonand fails on an extra, missing or empty file and on a non-version tag.migrate legacyandmigrate septemberrestore the 1.2.6 files from a MeshCentral checkout and from GitHub and verify every size and SHA384.1.2.0,1.2.0-beta.1,v1.2.0,legacy-1.2.6,testing-sep2026andMeshCentral_v1.1.0using GitHub's filter pattern rules.