Conversation
|
Unfortunately, we cannot accept this PR because the package.json has been modified with packages that won't work on Linux machines/docker Also u say this works with a fork of the meshagent for Android rather than the official build What might be better is u convert this into a plugin! EDIT: ok, I had a think, we might accept it, but u need to fix the package.json, please, as this will break linux machines! |
|
I restored package.json and package-lock.json as they were previously. For Android, I'm going to check it asap thank you! |
|
Thanks for fixing that! If possible, please can u also apply ur changes to the new modern ui? We aren't really making any major changes to the old ui anymore and we are trying to push people towards the new ui! You can use the new ui by clicking the diamond (top right) and click the bottom 3 lines icon OR by adding |
|
I think there is a typo in default3.handlebars at row 9343: |
|
plz can u resolve these conflicts and we might be merging it!? |
|
just another one, we already use openlayers v4.2.0 |
Restored leaflet style tag and js tag inside generateCustomJSTags and generateCustomCSSTags
|
@si458 I have ported map from leaflet to openlayer. Please consider to remove Content-Security-Policy from webserver.js if that's okay for you: there is an open route for *.openstreetmap. Regarding Custom CSS and JS tags, I placed them under webserver.js with no extra config file modification for using leaflet but, if it's not necessary anymore, consider only last commit. |
|
@mpedy we already add to the CSP IF you have geolocation enabled
|
we are about to add 600 tablets to a selfhosted one, will it be a good test ? :) |
|
@pofa2007 we havent updated the android agent to include these feature yet, this is why we havent merged it yet |
|
@si458 we found on old Android releases the current agent still works, on the last Android release it does not . thanks and regards |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically closed due to inactivity. If you'd like to continue working on it, please reopen it. |
Added lock option for mobile device and a geolocalization tab for getting position of android mobile device with a fork of MeshCentralAndroidAgent
CLIENT SIDE: Ylianst/MeshCentralAndroidAgent#42