Repository navigation
Conversation
Collaborator
|
Please can you remove the tests folder |
Toomad23
force-pushed
the
fix/login-token-allowlist-8165
branch
from
September 27, 2026 20:54
6f4fa19 to
6a28609
Compare
Author
|
Removed the test directory as requested. The diff now contains only the one-line fix in |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8165.
Align the
createLoginTokenhandler with the allow-list semantics already used byComposeWebFeatures: allow an explicitly listed user or a user with at least one listed link; reject everyone else.The old predicate looks for any unlisted link, incorrectly rejecting a permitted group member who also has another link. Missing, null or empty
user.linkscan also bypass the group allow-list check. Negate the entire positive membership expression rather than changing only the comparison inside.some().This affects an already authenticated session with an array-valued
passwordRequirements.loginTokenspolicy, not anonymous login. Existing restrictions on token-authenticated sessions, boolean policies, command names and expiry values remain unchanged.Verification (local harness, not part of the diff)
Per maintainer feedback, the regression harness is kept locally and is not included in this PR. It uses Node's built-in test runner with no extra dependencies. The harness extracts and executes the actual validation block from
meshuser.jswith the real common validators. It does not create tokens, connect to a server, or write a database.Against upstream
029b7338ecfeeacc65da3b5a1a4cc069baeb2f65: 6 failures / 16 tests. After the fix: 16 / 16 passed.Coverage: absent/null/empty links, unrelated and matching groups, mixed matching/unrelated memberships, explicit user IDs, empty allow-list, omitted/true/false policies, token-session rejection, invalid name and expiry.
The local harness was re-run after removing the test directory; all checks still pass. The PR diff now contains only the one-line
meshuser.jsfix.Scope and QA