Repository navigation
Conversation
- Ensured unique IDs for `<iframe>` elements in `default.handlebars` and `default3.handlebars` by adding `id="fileDownloadFrame"`. - Modified backup logic to handle large downloads without interrupting web socket connections or prematurely removing download frames. Added error handling and user feedback via modal dialogs. - Refactored backup process in `db.js`: - Removed unnecessary child process exit handlers for MongoDB, MySQL, and PostgreSQL backups to simplify execution flow. - Introduced a `zipStatus` variable to track archiving errors independently of `backupStatus`, ensuring isolated error management for different backup steps. - Updated logging and error-handling logic for zip creation to improve reliability and error reporting. Fixes Ylianst#8193
Collaborator
|
@PTR-inc please can you confirm this fix against the issue? |
Contributor
|
Will check it tonight |
Contributor
Author
They're still logged. The exit handler only added a "child process exited with code N" line on top of the exec callback's error, and ran createBackupfile a second time, which is where the duplicate "Backup failed" came from. |
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
window.location.href. Firefox closes the page's WebSockets when a top-level navigation starts, even one that ends in a download, so the UI disconnected and reloaded a few seconds later, cancelling the download while the zip was still being built. backup.zip now loads in the existing hiddenfileDownloadFrame(downloadFile()drops its frame after 10s, too soon for a large backup), and errors from it show in a dialog. Chrome wasn't affected.BACKUPFAIL_ZIPCREATEagain after the reset. Zip failures are now tracked per run.createBackupfiletwice (exec callback and exit handler). Only the exec callback continues now.Only default and default3 have the backup download; mobile and sharing don't.
Resolves #8193
I understand that I am responsible for and able to explain every line of code I submit.