Skip to content

Validate size and offset in recordings playback requests - #8198

Open
acebear17 wants to merge 1 commit into
Ylianst:masterfrom
acebear17:recordings-get-validation
Open

acebear17 wants to merge 1 commit into
Ylianst:masterfrom
acebear17:recordings-get-validation

Conversation

@acebear17

Copy link
Copy Markdown

Summary

In this pull request, the following changes are made:

  • In the recordings websocket 'get' handler, check that size and ptr are non-negative integers and cap size at 1MB.
  • Wrap the buffer/read block in try/catch, like the other websocket handlers.
  • Skip sending if fs.read returns an error.
Please follow this checklist to avoid unnecessary back and forth (click to expand)
  • 🧠 I used LLMs/AI in this contribution and reviewed all generated content.
    I understand that I am responsible for and able to explain every line of code I submit.
  • 🔍 Any UI changes adhere to visual style of this project.
  • 🛠️ I have self-reviewed and self-tested my code to ensure it works as expected.
  • 🤖 I added or updated automated tests where appropriate.
  • 📄 Documentation updates are included (if applicable).
  • 🧰 Dependency updates are listed and explained.
  • ⚠️ CI passes and is green.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant