Repository navigation
Remove agent-release.json and limit Android releases to version tags - #55
Merged
Merged
Conversation
- Limited the `android-release.yml` tag filter to `[0-9]+.[0-9]+.[0-9]+`. `*.*.*` also matched `legacy-1.2.6`, so publishing that migration draft started a release run that failed at "Require a version tag". - Removed the `agent-release.json` manifest, the step that generated it and the Node setup it needed. MeshCentral verifies `meshagent_android.apk` against the SHA384 pinned in its own `agents/agent-defaults.json`, or GitHub's SHA256 asset digest when it is imported. - Removed `release-files.json` and reduced `agent-release.js` to the migration it is still used for, reading the migration tag from `release-migration.json`. - Updated `docs/releasing.md`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[0-9]+.[0-9]+.[0-9]+.*.*.*also matchedlegacy-1.2.6, so publishing that migration draft started a release run that failed at "Require a version tag".agent-release.json. MeshCentral verifiesmeshagent_android.apkagainst the SHA384 pinned in its ownagents/agent-defaults.json, or GitHub's SHA256 asset digest when it is imported, so the manifest was never read and went stale whenever the draft APK changed.release-files.jsonthat only existed for the manifest, and read the migration tag fromrelease-migration.json.Relates to #48 and Ylianst/MeshCentral#8177
Testing
migrate legacyrestores the 1.2.6 APK from a MeshCentral checkout and from GitHub and verifies its size and SHA384. The tag filter was checked against1.0.24,legacy-1.2.6andtesting-sep2026using GitHub's filter pattern rules. The release workflows have not been run.