Make USE_ACC configurable via environment variable#84
Merged
Conversation
Default behavior is unchanged (GPU enabled). Setting USE_ACC=OFF in the environment before cmake configure disables OpenACC/GPU compilation, using the existing CPU fallback paths in subdirectory CMakeLists files. Also switch from True/False to ON/OFF convention for consistency with ZEST and standard CMake idioms. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set(USE_ACC True)with env-var override: defaultsON, respectsUSE_ACC=OFFfrom shellChanges
CMakeLists.txt:set(USE_ACC True)→set(USE_ACC ON)with$ENV{USE_ACC}override + status messageTest plan
issue-78-cpu-buildsbranch (which points at this SlaterGPU branch): check ZimmermanGroup/ZEST CI runsUSE_ACC=OFF pixi installbuilds SlaterGPU without GPU flags (tested via ZEST locally)pixi install(no env var) still builds with GPU as before🤖 Generated with Claude Code