Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the jellium integral routines to consistently use the atomic number (
atno) and the angular grid size (size_ang) throughout the codebase. The code now uses the right grid size for computing jellium integrals. For computing the external potential due to the positive background, Ne is replaced by the atomic number to handle charged jellium spheres correctly.Generalization and parameterization:
Updated all relevant function signatures in
src/integrals/jellium_ints.cppand their declarations ininclude/jellium_ints.hto acceptint* atno(atomic numbers) andint size_ang(angular grid size) instead of relying on hardcoded or inferred values. This affects functions likecompute_STEn_jellium,compute_Vr_jellium, andcompute_4c_ol_jellium. [1] [2] [3] [4]Refactored
do_jelliuminexamples/main.cppto acceptatnoandsize_angas parameters, updating all calls and removing local hardcoded atomic number arrays. [1] [2] [3]Correctness and output improvements:
atno[0](atomic number) instead ofNe(number of electrons) where appropriate, ensuring that the correct physical values are used in both computation and output. [1] [2]Consistent use of angular grid size:
nangwithsize_angin grid allocations, kernel launches, and data movement for angular grids, ensuring that the angular grid size is consistently applied throughout the code. [1] [2] [3] [4] [5] [6] [7]Function call and implementation updates:
examples/main.cppandsrc/integrals/jellium_ints.cppto match the new parameter lists, ensuring code consistency and preventing mismatches. [1] [2] [3]