Fixes #30 and updated the Dockerfile since it fails to build and compile#45
Open
m-primo wants to merge 4 commits intoZizzyDizzyMC:masterfrom
Open
Fixes #30 and updated the Dockerfile since it fails to build and compile#45m-primo wants to merge 4 commits intoZizzyDizzyMC:masterfrom
m-primo wants to merge 4 commits intoZizzyDizzyMC:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I mentioned in #30, I updated the
siteurlissue and added a new config key calledstrict-site-url, if set totrueit would check thesiteurlproperly and won't upload if thesiteurldoesn't match the request url, also I added an error message instead of empty messageCSRF mismatch, and if set to false, it would just pass that and go on and upload the file, just like the API, since the API, doesn't check for this.This is the first key change in code (notice
Config.strictSiteUrlandCSRF mismatch):I'm not sure how to reference a code from the source in here, so here's a link to this diff, m-primo@0bfba9f#diff-148c9bdc57383bd2555164d3c4336f2bcbe03d4edfb3a8649c7c8202260e6569R55
Here are screenshots:
siteurlto/:siteurlto empty string"":Commit URL: m-primo@0bfba9f
This was for the first change.
As for the second change, I have updated the Dockerfile after your commit on Go version updates since it fails to compile and build on Docker.
Commit URL: m-primo@dfa1152
Additionally, I added a
compose.ymlfile, updated the readme, built a self-contained binary release https://github.com/m-primo/linx-server/releases/tag/release, and uploaded the latest updates to the GitHub Container Registry https://github.com/m-primo/linx-server/pkgs/container/linx-server, since there was no binary release and no public image.I have tested all of this on my own machine, and I have a website on a domain and all the implemented changes are working perfectly fine. I could send you the URL with some credentials (since its behind authentication) to test it live if you want.
I really wish for this pull to be merged for everyone wants to run the instance on the last updates.
Thanks.