docs(spec): Rename PushNotificationConfig to TaskPushNotificationConfig#1981
Open
Iwaniukooo11 wants to merge 2 commits into
Open
docs(spec): Rename PushNotificationConfig to TaskPushNotificationConfig#1981Iwaniukooo11 wants to merge 2 commits into
Iwaniukooo11 wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request renames PushNotificationConfig to TaskPushNotificationConfig across the documentation files to align with the updated schema. The reviewer feedback suggests utilizing the stable HTML anchor #TaskPushNotificationConfig instead of fragile, section-number-based anchors to ensure link stability if sections are reordered or renumbered.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Iwaniukooo11
changed the title
Iwaniukooo11
force-pushed
the
mateusziwaniuk/docs_fix_push-notification-config
branch
from
d3f5801 to
4374b82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves two macro rendering errors in
specification.mdwhere the old, removedPushNotificationConfigandCreateTaskPushNotificationConfigRequestmessages were being called.Since these were flattened into
TaskPushNotificationConfigin v1.0, this PR aligns the documentation and cross-page links (instreaming-and-async.md) to useTaskPushNotificationConfigconsistently.4.3.1 after update:
10.4.7 after update:
