You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Jan 14, 2026. It is now read-only.
Thanks for this, I appreciate it. But there are three issues I see. First one being that you just use an array and indices to access them, I'd prefer if it was an object that maps a key to the message so that you actually know what you are accessing (like strings[languageId].noFav instead of string[langaugeId][0]). Second issue is the naming, Language_ID and Language, they should rather be something like strings and locale/language. You could also just use the strings property inside the configwhich does exactly that, then you just access the strings using this.strings.noFav. Only problem with that would be that it does not accept sub languages, so there could just be zh and not zh-TW and zh-CN. You could however also make a PR or create an issue in the repo for the library to implement that. The third problem is nothing you have control of but there currently is another PR (#76) that I would consider more important than this one, I will probably merge that soon. You would probably need to update this afterwards (with my previous points in mind) and then I'd merge it.
(Also I'd prefer if you'd keep my formatting, I don't like whitespace changes in my stuff. Maybe you can disable your linter or formatting for this small change.)
Thank you! I see. I will wait for the PR(#76) merger before submitting the new multilingual translation system version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.