Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "@wagmi/core@2.22.1": | ||
| version "2.22.1" | ||
| resolved "https://registry.yarnpkg.com/@wagmi/core/-/core-2.22.1.tgz#de4b5019971dcf033ea5f7484add66900da7897c" | ||
| integrity sha512-cG/xwQWsBEcKgRTkQVhH29cbpbs/TdcUJVFXCyri3ZknxhMyGv0YEjTcrNpRgt2SaswL1KrvslSNYKKo+5YEAg== | ||
| dependencies: |
There was a problem hiding this comment.
Align @wagmi/core with wagmi upgrade
Only wagmi was bumped to ^2.19.0, which pulls @wagmi/core@2.22.1 into the lockfile while package.json still lists @wagmi/core as ^2.17.1. Yarn will install both versions, and the app imports Emitter and getConnectorClient directly from @wagmi/core, so those calls will run against a different store than the config created by wagmi 2.19. In practice this causes providers and connectors to fail because the config objects are no longer recognized across versions. Update the explicit @wagmi/core dependency to the same version (or remove it so it dedupes) before shipping the upgrade.
Useful? React with 👍 / 👎.
General Changes
Developer Notes
Add any notes here that may be helpful for reviewers.
Reviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
.env.examplefile as well as the pertinant.github/actions/*files