Fix: Ensure email text visibility in Dark Mode (#449) - #452
Fix: Ensure email text visibility in Dark Mode (#449)#452IzzaldinSamir wants to merge 5 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughIncoming non-text messages apply ChangesMessage styling
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/shared-ui/assets/styles/main.scss`:
- Around line 262-264: In the affected style rule, add an empty line between the
`@apply` declaration and the color-scheme: light declaration to satisfy
Stylelint’s declaration-empty-line-before rule; leave the remaining declarations
unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 3812dafa-8161-4155-8d70-62440ad1436b
📒 Files selected for processing (2)
frontend/apps/main/src/features/conversation/message/MessageBubble.vuefrontend/shared-ui/assets/styles/main.scss
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/shared-ui/assets/styles/main.scss`:
- Around line 262-265: Remove the Markdown backticks surrounding the CSS
declarations in the affected style block, including the `background` value, so
`@apply`, `color-scheme`, and `background` are valid SCSS/CSS syntax and the
dark-mode email canvas rule compiles successfully.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: f6d8aa8d-8183-4d46-99bb-c78e2144b8cb
📒 Files selected for processing (1)
frontend/shared-ui/assets/styles/main.scss
Closes #449
The Bug
When Dark Mode is enabled, incoming emails containing inline styles (e.g.,
style="color: #000000") become invisible against the dark background.The Fix
As discussed in the issue, many email clients resolve this by enforcing a light background for raw email content.
I added Tailwind classes (
dark:bg-white dark:text-black dark:p-4 dark:rounded-md) to themessageContentElwrapper around the<Letter>component. This ensures the email is rendered on a clean, light canvas when Dark Mode is active, preserving complex HTML layouts and ensuring black inline text remains perfectly readable.Summary by CodeRabbit