fix(ui): make dialogs fit a narrow viewport - #472
Open
pat-s wants to merge 1 commit into
Open
Conversation
`DialogContent` and `AlertDialogContent` are `w-full max-w-lg` with no side inset, no max height and no vertical scrolling, and `sm:rounded-lg` only applies from 640px. In a window narrower than that they render edge to edge with square corners, and cannot be scrolled when taller than the viewport. Add a 1rem side inset, `max-h-[calc(100dvh-2rem)]` with `overflow-y-auto`, and make the radius unconditional. At 640px and above `max-w-lg` still governs the width, so nothing changes there. Fixing the two primitives covers all 17 dialog call sites.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughDialog and alert dialog content styling now uses viewport-aware sizing, vertical scrolling, and consistent rounded corners. ChangesDialog content styling
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DialogContentandAlertDialogContentarew-full max-w-lgwith no side inset, nomax-hand nooverflow-y-auto, andsm:rounded-lgonly applies from 640px. Below that they render edge-to-edge with square corners, and can't scroll when taller than the viewport.Adds a 1rem side inset,
max-h-[calc(100dvh-2rem)]+overflow-y-auto, and makes the radius unconditional. At ≥640pxmax-w-lgstill governs, so nothing changes there.Two files, covers all 17 dialog call sites. Refs #470
Summary by CodeRabbit