Skip to content

Add BUILD_PATH env variable to customise naming of production folder #75

Open
Open
Add BUILD_PATH env variable to customise naming of production folder#75
Labels
bugenhancement

Description

@lucafalasco
lucafalasco
opened on Nov 16, 2020

Would be nice to change the path of the production folder, in my use case we have to create different folders at build time for each different language.
Example:

build/
-- app.js
-- index.html
-- assets/
-- fr/
---- app.js
---- index.html
-- de/
---- app.js
---- index.html

BUILD_PATH=build/fr

accurapp/packages/webpack-preset-accurapp/index.js

Line 300 in 7c87d0d

path: path.resolve('./build'),

Activity

  1. lucafalasco
    added
    enhancement
    on Nov 16, 2020

  2. lucafalasco commented on Nov 16, 2020

    @lucafalasco
    lucafalasco
    on Nov 16, 2020
    ContributorAuthor

    Also maybe this line should be reverted?

    d432792#diff-9b7d14c4a3da62774803e2fe1499ba9cff536bfd18e4adf22a46b5e8012f4aa7L30-R29

    It would work perfectly if reading the path from config.output.path

  3. marcofugaro commented on Nov 16, 2020

    @marcofugaro
    marcofugaro
    on Nov 16, 2020
    Contributor

    Oops didn't realize that was an issue, I'll put back the config.output.path thing.

  4. marcofugaro
    added
    bug
    on Nov 16, 2020
  5. marcofugaro
    closed this as completedin abb0756on Nov 16, 2020

  6. marcofugaro commented on Nov 16, 2020

    @marcofugaro
    marcofugaro
    on Nov 16, 2020
    Contributor

    Done.

  7. lucafalasco commented on Nov 16, 2020

    @lucafalasco
    lucafalasco
    on Nov 16, 2020
    ContributorAuthor

    @marcofugaro nice, although I'm going to reopen this for the main issue which is supporting a BUILD_PATH env variable ok?

  8. lucafalasco
    reopened this on Nov 16, 2020

  9. marcofugaro commented on Nov 16, 2020

    @marcofugaro
    marcofugaro
    on Nov 16, 2020
    Contributor

    Sure, is setting it from the webpack.config.js not enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugenhancement

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions