chore: make mypy default mode pass with zero errors#6
Merged
Conversation
The SDK had 14 [no-any-return] errors across 7 files. Each came from the same shape: a function declared a precise return type (e.g. ``dict[str, Any]`` or ``str | None``) but actually returned ``Any`` through ``response.json()``, ``msg.content``, or a similar bridge to an untyped third-party SDK. Fix is mechanical and behavior-preserving: bind the bridge value to a locally typed variable, then return that. The runtime is identical; mypy can now narrow. Verified: ``mypy promptguard/`` -> "Success: no issues found in 20 source files." All 117 tests still pass. Lint and format are clean. No public API change. No dependency change. Patch-bump worthy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drives `mypy promptguard/` from 14 errors → 0 with mechanical, behavior-preserving fixes.
All 14 errors were the same shape: a function declared a precise return type (e.g. `dict[str, Any]` or `str | None`) but actually returned `Any` through `response.json()`, `msg.content`, or a similar bridge to an untyped third-party SDK.
Fix: bind the bridge value to a locally typed variable, then return that. The runtime is identical; mypy can now narrow.
Files touched
Test plan
Verified locally:
```
$ ruff check . # All checks passed!
$ ruff format --check . # 29 files already formatted
$ mypy promptguard/ # Success: no issues found in 20 source files
$ pytest tests/ # 117 passed, 1 skipped
```
Plus a smoke test on the redaction helpers to confirm runtime behavior is identical.
Versioning
No public API change. No dependency change. Patch-bump worthy if you decide to release.