Skip to content

Persistence Options + Comprehensive README#60

Open
AngriestBird wants to merge 2 commits intoacemod:mainfrom
AngriestBird:main
Open

Persistence Options + Comprehensive README#60
AngriestBird wants to merge 2 commits intoacemod:mainfrom
AngriestBird:main

Conversation

@AngriestBird
Copy link
Copy Markdown

@AngriestBird AngriestBird commented Mar 15, 2026

Changes

  • Adds persistence options for the Dockerfile
  • Comprehensive improvements to the Dockerfile

Issues

Adds instructions in README to enable persistence as well as additional information and places for documentation.

Closes #44

* Replication Configuration

* Gitignore and docker-compose

* Updated the persistence_default.json

* persistence working

* updated

* updated

* README
@AngriestBird AngriestBird changed the title Persistence Options + Comprhensive README Persistence Options + Comprehensive README Mar 15, 2026
@jacksga
Copy link
Copy Markdown

jacksga commented Apr 11, 2026

Hey @BrettMayson / @coyotan,

any chance you or one of your colleagues could take a look at this and maybe merge it? I'd love to have persistence :)

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds optional persistence configuration support to the container startup flow and significantly expands the README to document available environment variables (including persistence-related settings), addressing the “Persistence How?” documentation gap (Issue #44).

Changes:

  • Add PERSISTENCE_* environment variables and inject a game.gameProperties.persistence section into the generated server config when set.
  • Add a persistence_default.json template file and copy it into the image.
  • Expand README variable documentation across Steam/Network/RCON/Game/Game Properties/Persistence sections.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
README.md Adds comprehensive ENV documentation and a new Persistence section with examples/links.
launch.py Generates persistence config in docker_generated.json when PERSISTENCE_* envs are provided.
Dockerfile Introduces PERSISTENCE_* env defaults and includes persistence_default.json in the image.
persistence_default.json Provides a default/template persistence JSON structure (databases/storages).
.gitignore Ignores reforger/ directory artifacts.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md
Comment thread README.md
Comment thread README.md Outdated
Comment thread Dockerfile
@AngriestBird
Copy link
Copy Markdown
Author

@BrettMayson I resolved the immediate comments. Please let me know if there's any other gaps. I do have a follow-up feature branch that implements ALL 1.6 parameters and updated docs as well we can start to look at as well as upgraded the container to a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Persistence How?

3 participants