Switch to ESLint projectService #1133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the TypeScript configuration by consolidating tsconfig.base.json into tsconfig.json and removing tsconfig.eslint.json. It also updates ESLint configuration to use TypeScript's newer projectService API and the Node.js import.meta.dirname instead of the __dirname workaround.
- Consolidated TypeScript configurations into a single
tsconfig.jsonfile - Updated ESLint to use TypeScript's
projectServiceAPI withallowDefaultProject - Modernized ESLint config to use
import.meta.dirnameinstead ofpath/fileURLToPathworkaround
Reviewed Changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Consolidated base configuration directly into main config, removing the extends clause |
| tsconfig.eslint.json | Deleted - no longer needed with projectService approach |
| tsconfig.base.json | Deleted - configuration merged into tsconfig.json |
| package-lock.json | Updated dependency tree to reflect removed @rollup/rollup-linux-x64-gnu from main dependencies |
| jest.config.js | Updated to reference tsconfig.json instead of tsconfig.eslint.json |
| eslint.config.mjs | Updated to use projectService API and import.meta.dirname; removed path/fileURLToPath imports |
Dunklas
added a commit
to DeviesDevelopment/workflow-timer
that referenced
this pull request
Nov 13, 2025
- Consolidate typescript configuration files - Use eslint projectService This is equivalent to actions/typescript-action#1133 in the typescript-action template.
Dunklas
added a commit
to DeviesDevelopment/workflow-timer
that referenced
this pull request
Nov 13, 2025
- Consolidate typescript configuration files - Use eslint projectService This is equivalent to actions/typescript-action#1133 in the typescript-action template.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the ESLint configuration to improve compatibility and project resolution, while also removing unused TypeScript configuration files. The main changes focus on simplifying TypeScript project handling for ESLint and cleaning up configuration files.