Conversation
…sed by duplicates and points
…eferences are used
Member
Author
|
As references are now added automatically for duplicates, reference support for the DE9IM computation and I also fixed a very subtle bug in the duplicate removal process which only manifested itself on Mac machines (it was only triggered by a very specific sorting order of events with the same X coordinate in the sweep event queue) and was impossible to reproduce on non-Mac machines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR,
spatialjoinautomatically detects duplicate geometry parts above a threshold size (number of anchor points). This works across multi geometries. Duplicates are replaced by references to the original geometry. Duplicate removal is done by iterating over the event list once (sorted by leftxcoordinate) and checking duplicates in blocks of equalxcoordinates.Also changed along the way: previously, if at least one reference geometry was present, every geometry was first compared to itself as a duplicate to resolve potential references. This added a small, but measurable time overhead. This is now replaced by special "self-check" events in the event list which are added for geometries which are referenced somewhere and which trigger such a self check.