Skip to content

Add family functions & remove manual seealso#780

Merged
peterdesmet merged 24 commits into
adokter:masterfrom
YohanSassi:family
Jul 2, 2026
Merged

Add family functions & remove manual seealso#780
peterdesmet merged 24 commits into
adokter:masterfrom
YohanSassi:family

Conversation

@YohanSassi

Copy link
Copy Markdown
Collaborator

fix #531

@YohanSassi YohanSassi requested a review from peterdesmet June 25, 2026 12:02
Order:

```
@describeIn
@rdname/name
@param
@returns
@family
@Rdname
@export
@importFrom
@Keywords
@details/section
@references
@examples
```

Also:
- remove whitespace
- use `@returns` not `@return`
- remove importFrom

This change largely has no effect on the rd files, except for some minor whitespace changes and:
- attribute_table.Rd which now has the description correctly shown as description (not part of the ... param)
- integrate_to_ppi: don't duplicate references
Document digits param with inheritParams base::print
It was currently used inconsistently. I've now applied `@noRd` for all. I've also removed `@keywords internal` as that is reserved for helper functions that do need an `Rd` file, but not be listed in the function overview.

For the public beam_profile I had to update the inheritParams form gaussian_beam_profile (noRd) to a beam_height and beam_width (both public)

Two functions are remove from the NAMESPACE: read_stout and methods, as

Ping @adokter @bart1
They're all listed under the same rdname
Makes more sense to group them under param and scan then under polar accessor functions
Avoids having the clunky polar accessor functions

@peterdesmet peterdesmet left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @YohanSassi!


Additional changes

  • Use consistent order for roxygen tags aac4030. This also fixes a description that was listed as a param in attribute_table() and double references in integrate_to_ppi()
  • Export print functions aac4030
  • Don't create rd for internal functions 99062de
  • Rename Ops to operators.Rd ca3895b

Changes to function reference

Reading radar data

  • print(<pvol>) added
  • select(<pvol>), select(<scan>) repeated
  • get_elevation_angles() repeated

Inspecting radar scans

  • print(<scan>) added
  • select(<pvol>), select(<scan>) moved here from "Manipulating radar scans"
  • print(<param>) added

Manipulating radar scans

  • No changes (other than listed above)

Plotting radar scans

  • Deprecated functions not listed
  • print(<ppi>) added

Creating vertical profiles of biological targets

  • nexrad_to_odim() not repeated

Reading vertical profile data

  • read_vpts() moved here from "Manipulating vertical profile data"

Inspecting vertical profile data

  • New section, to separate from reading functions
  • Moved here from "Reading vertical profile data":
    • example_vp()
    • plot(<vp>)
    • summary(<vp>), etc. and print(<vp>) added
  • Moved here from "Manipulating vertical profile data":
    • example(<vpts>)
    • plot(<vpts>)
    • [(<vpts>) (now its own page)
    • get_quantity()
    • summary(<vpts>), etc.

Manipulating vertical profile data

  • Moved here from "Accessing vertical profile metadata"
    • rcs<-()
    • sd_vvp_threshold<-()

Integrating vertical profiles

  • No changes

Accessing vertical profile metadata

  • No changes (other than listed above)

Radar beam geometry

  • No changes

Other functions

  • No changes

@peterdesmet peterdesmet merged commit d46eec0 into adokter:master Jul 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use function @family rather than manually maintaining @seealso

2 participants