fix: security audit round 5 + email display bugs#75
Merged
Conversation
… bugs - SMTP: bounded read_line_limited() prevents OOM from newline-free input - SMTP: preserve leading whitespace in DATA mode for MIME header folding - Cache: fix double-counting on key replacement in set() size check - Routes: block Set-Cookie/Location/CSP headers on main domain /r/ routing - Config: reject known JWT_SECRET placeholders and enforce min 32 chars - Sentry: scrub token/share params from all breadcrumb types + event URLs - Frontend: fix text tab fallback, remove squished base64 raw SMTP block - Deps: bump jsonwebtoken 9.2 → 9.3 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
read_line()withread_line_limited()usingfill_buf()/consume()— prevents OOM from newline-free input (AIS-ASO-REF-003)trim_end()instead oftrim()in DATA mode to preserve MIME header folding — fixes HTML/text body extraction for multipart emailsset()— prevents false "storage exceeded" on key replacement (AIS-ASO-REF-004)Set-Cookie,Location,CSPon main domain/r/routing (AIS-ASO-REF-009)token/shareparams from all breadcrumb types +event.request.url(AIS-ASO-REF-005)Test plan
cargo clippy -- -D warningspassescargo test— 79 passed, 0 failedbun run lint+bun run tsc --noEmit— clean🤖 Generated with Claude Code