Column number override - #34
Open
stribioli wants to merge 2 commits into
Open
Conversation
Introduces a new option to manually set the number of columns in the layout. If 0, the usual autosensing applies. Layout is now regenerated every time the SettingsDialog is closed with ok. This might be unwanted.
adrienverge
requested changes
Sep 29, 2016
adrienverge
left a comment
adrienverge
left a comment
Owner
There was a problem hiding this comment.
Hey @sassospicco, looks good!
Would it be possible for you to change the settings appearance? I'm thinking about something like:
Layout
------
[x] automatic number of columns: | |
| dialog.destroy() | ||
| if self.history: | ||
| self.render_preview() | ||
| self.regenerate_layout() |
Owner
There was a problem hiding this comment.
Please regenerate layout only if the number of cols changed. Users don't want their collage to change if they just chose a different border color.
Contributor
There was a problem hiding this comment.
@adrienverge, I see that it has not been decided for a long time. I can reopen this PR with line self.regenerate_layout() instead of self.render_preview(). Ok?
Owner
There was a problem hiding this comment.
@andreynovikov95 I'm not sure it's a good idea, as this PR would bring more complexity to the tool, which is not needed here. But thanks for proposing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thanks for your software!
I introduced the ability to manually set the number of columns. I find it quite useful, since the new auto-layout algorithm introduced in 1.4 generates strange grids sometimes.
This is a quick-and-dirty implementation, feel free to do whatever you please with it :)