ateapi: bracket IPv6 atelet addresses when dialing - #785
Open
Yuan Gao (ygao-g) wants to merge 1 commit into
Open
ateapi: bracket IPv6 atelet addresses when dialing#785Yuan Gao (ygao-g) wants to merge 1 commit into
Yuan Gao (ygao-g) wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
ateapi built its atelet dial target by concatenating the pod IP with ":8085", which is wrong for IPv6: the target has to be [fd00:10:244::7]:8085, not fd00:10:244::7:8085, and net.Dial rejects the unbracketed form with "too many colons in address". grpc.NewClient connects lazily, so this surfaced only as Unavailable on every snapshot and restore RPC, reading as a storage bug rather than a networking one. Use net.JoinHostPort, which brackets the host only when it is an IPv6 literal. Also lift the duplicated 8085 literal into internal/ateletport.Default, shared by atelet's --port flag and ateapi's dial target; nothing enforced agreement between the two binaries before.
Yuan Gao (ygao-g)
force-pushed
the
ateapi-ipv6-dial-atelet
branch
from
August 6, 2026 19:45
09874e2 to
d4737aa
Compare
Author
| // Default is the port atelet's gRPC server listens on: it is the default of | ||
| // atelet's --port flag (cmd/atelet/main.go) and the port ateapi dials when | ||
| // it connects to an atelet | ||
| // (cmd/ateapi/internal/controlapi/dialer.go). It is deliberately untyped so |
Collaborator
There was a problem hiding this comment.
Please go through your code comments and remove the agent language (extra verbose comments)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #246
ateapi built its atelet dial target by concatenating the pod IP with
":8085", which is wrong for IPv6: the target has to be
[fd00:10:244::7]:8085, notfd00:10:244::7:8085, andnet.Dialrejectsthe unbracketed form with "too many colons in address".
grpc.NewClientconnects lazily, so this surfaced only as
Unavailableon every snapshotand restore RPC, reading as a storage bug rather than a networking one.
Use
net.JoinHostPort, which brackets the host only when it is an IPv6literal.
Also lifts the duplicated 8085 literal into
internal/ateletport.Default,shared by atelet's
--portflag and ateapi's dial target; nothing enforcedagreement between the two binaries before.
This is verifiable without an IPv6 cluster — the test asserts the resolved
ClientConn.Target()over a fake pod indexer for v4, v6, and::1, so itdoes not depend on the dual-stack kind work in #246.
🤖 Generated with Claude Code