controlapi: refactor workflows to typed ensure-steps - #797
Open
Troy Chiu (troychiu) wants to merge 5 commits into
Open
controlapi: refactor workflows to typed ensure-steps#797Troy Chiu (troychiu) wants to merge 5 commits into
Troy Chiu (troychiu) wants to merge 5 commits into
Conversation
Troy Chiu (troychiu)
force-pushed
the
refactor/ensure-step-workflows
branch
2 times, most recently
from
August 7, 2026 21:11
39faf35 to
4b3fffb
Compare
Troy Chiu (troychiu)
force-pushed
the
refactor/ensure-step-workflows
branch
from
August 7, 2026 22:05
4b3fffb to
6c1a66f
Compare
Troy Chiu (troychiu)
force-pushed
the
refactor/ensure-step-workflows
branch
from
August 7, 2026 22:35
6c1a66f to
4f7d649
Compare
Troy Chiu (troychiu)
marked this pull request as ready for review
August 7, 2026 22:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #554
Each workflow becomes a plain method orchestrating typed, idempotent ensureX steps, e.g.:
Each
ensureXIsCompleteCheckPrerequisite*ResumeState.There is one behavioral change: worker ownership/eligibility validation for a re-entered resume now runs before volumes are attached (it used to run in
CallAteletRestoreStep's prerequisite, after attach), so a resume that is about to crash on a reassigned/ineligible worker no longer attaches volumes to it first.