test: increase timeouts on flaky e2e and syncer tests - #800
Open
Aditya Shantanu (aditya-shantanu) wants to merge 1 commit into
Open
test: increase timeouts on flaky e2e and syncer tests#800Aditya Shantanu (aditya-shantanu) wants to merge 1 commit into
Aditya Shantanu (aditya-shantanu) wants to merge 1 commit into
Conversation
Fixes agent-substrate#799 TestActorLifecycle, TestDurableDirLifecycle, TestMultipleDurableDirLifecycle: callActor retried for 30s but xDS routes in atenet-router aren't always propagated by the time the actor reaches STATUS_RUNNING. Increase the callActor deadline to 90s and waitForActorStatus timeout to 120s to give the route-sync more headroom on loaded CI runners. TestSyncer_UpdateWorker_RetryOnVersionConflict: The syncer's rate-limiting work queue adds backoff between retries; the previous 5s poll window was occasionally exhausted before the second reconcile attempt completed. Increased to 15s.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #799
What changed and why
internal/e2e/suites/demo/demo_test.gocallActordeadline: 30s → 90swaitForActorStatustimeout: 60s → 120sTestActorLifecycle,TestDurableDirLifecycle, andTestMultipleDurableDirLifecyclewere failing with:The actor reaches
STATUS_RUNNINGbefore atenet-router's xDS routes are fully propagated.callActorwas already retrying, but the 30s deadline was exhausted before the route-sync completed on a loaded CI runner. The same xDS propagation lag was fixed for the networking ingress tests in #724 — this applies the same principle to the demo suite.cmd/ateapi/internal/controlapi/syncer_test.goPollUntilContextTimeout: 5s → 15sTestSyncer_UpdateWorker_RetryOnVersionConflictpolls for the worker to reflect a newSandboxClassafter a version conflict retry. The syncer's rate-limiting work queue adds backoff between reconcile attempts; on a loaded runner the second attempt occasionally lands after the 5s window closed.Checklist
go test ./...)Not addressed in this PR
TestLoaderConcurrentHandshakes(2 failures in sample) — failure logs were unavailable (run was re-triggered before logs could be retrieved). Tracked in #799 for follow-up once a reproduction is captured.