Repository navigation
fix(oidc): open the authorization page without waiting for the launcher - #133
Merged
Merged
Conversation
open::that waits for xdg-open to exit. In a Linux user session without a display the launcher can hang on the portal call; the wait blocks the runtime worker that holds the just-spawned callback server, so the login page never answers and enrollment times out. open::that_detached returns immediately. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Sep 30, 2026
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused change correctly prevents a hanging launcher from blocking the OIDC callback flow.
Review effort: Balanced
Findings: None
What changed in this PR
Updates OIDC browser launching so callback handling remains responsive when a Linux launcher hangs.
Changes:
- Replaces blocking
open::thatwith detached browser launching. - Documents why detachment is required.
| File | Description |
|---|---|
crates/agent/src/oidc.rs |
Launches the authorization page without waiting for the system launcher. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
peterj
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while working on #86; independent of the other PRs.
Why
open::thatwaits for the launcher to exit. In a Linux session without a display (for example a daemon started over SSH),xdg-opencan hang. The wait blocks the runtime worker that holds the just-spawned callback server, so the login page never answers and enrollment times out.Change
Open the page with
open::that_detached, which returns immediately.Tests
No unit test (it needs a hanging launcher). Lab-tested on an Ubuntu 24.04 VM with a user-mode daemon started over SSH: the login timed out before, and completes after. CI green.
🤖 Generated with Claude Code