Repository navigation
Conversation
Contributor
|
Verified this on a real macOS host, since that was the gap you flagged. macOS 27.0, arm64, Rust 1.98 (the pinned toolchain). On On this branch: So the real-host case matches what your Linux simulation predicted, and Thanks for picking it up, and for the credit. |
peterj
approved these changes
Oct 8, 2026
`CredentialCache::get` is used only by the llm_proxy test module, which is compiled on Linux only. On macOS and Windows the helper had no caller, and `make check` (clippy -D warnings) failed with `method get is never used`. The helper now carries the same cfg as the module. Fixes agentdesktop-dev#153. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
LutzLange
force-pushed
the
upstream/fix-153-linux-only-test-helper
branch
from
October 8, 2026 16:55
23186cc to
95a4a79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #153.
CredentialCache::getis only called from thellm_proxytest module, which is gated to Linux. On macOS and Windows the helper was compiled without a caller, somake check(clippy-D warnings) failed withmethod get is never used. The helper now carries the samecfg(all(test, target_os = "linux"))as the module, as @jagansanikommu suggested in the issue (thanks for the analysis).Checked on Linux:
cargo fmt --check,cargo clippy -p agentdesktop-agent --all-targets -- -D warnings, and the 41llm_proxytests pass. For the non-Linux case I turned the test module's gate off on Linux: before the change clippy reports the error from the issue, after it clippy passes. Not run on a real macOS or Windows host.🤖 Generated with Claude Code