Skip to content

feat(sec-core): integrate v2 with OTEL - #3174

Open
RemindD wants to merge 3 commits into
agentic-os-org:mainfrom
RemindD:feat/sec-core/v2trace
Open

RemindD wants to merge 3 commits into
agentic-os-org:mainfrom
RemindD:feat/sec-core/v2trace

Conversation

@RemindD

@RemindD RemindD commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Why

What changed

  • Integrate native OTel into v2 daemon and cli, preserving existing trace-context and metadata input sematics
  • Add tests and update docs

Related issue

User / Agent impact

Risk and compatibility

  • Public CLI, API, configuration, or documented behavior changed
  • Privileged or security-sensitive behavior changed
  • Cross-component contract changed
  • Migration or rollback guidance is needed

Validation

Documentation and rollback

@github-actions github-actions Bot added component:sec-core src/agent-sec-core/ scope:documentation ./docs/|./*.md|./NOTICE labels Sep 8, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d4e7ec5c0f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/agent-sec-core/v2/crates/data/asc-observability/src/runtime.rs Outdated
Comment thread src/agent-sec-core/v2/apps/asc-cli/src/lib.rs
@RemindD
RemindD force-pushed the feat/sec-core/v2trace branch 2 times, most recently from de1051c to 94449ea Compare September 9, 2026 02:58
@RemindD
RemindD marked this pull request as draft September 9, 2026 07:37
Assisted-by: Codex:0.153.4
Signed-off-by: Xingdong Li <XingDong.Li@linux.alibaba.com>
Route daemon startup and operational diagnostics through the bounded writer.
Use a bounded fallback for telemetry initialization failures and replace the
synchronous panic hook with a fixed, payload-free record. Preserve CLI business
output and error semantics; diagnostics may be dropped under back-pressure.

Add process coverage for stderr filled before startup, request rejection,
duplicate-daemon failure and shutdown with correlation logging enabled or off.
Route reconciliation, JSONL and SQLite warnings through the same bounded writer;
cover storage faults and worker shutdown with blocked stderr.

Fixes: 1138252afffa80e19576a179408aedd05a664634 ("feat(sec-core): integrate v2 with OTEL")
Assisted-by: Codex:0.153.4
Signed-off-by: Xingdong Li <XingDong.Li@linux.alibaba.com>
Signed-off-by: Xingdong Li <XingDong.Li@linux.alibaba.com>
@RemindD
RemindD force-pushed the feat/sec-core/v2trace branch from 94449ea to d3b9f7e Compare September 18, 2026 09:50
@RemindD
RemindD marked this pull request as ready for review September 18, 2026 09:53
@RemindD

RemindD commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:sec-core src/agent-sec-core/ scope:documentation ./docs/|./*.md|./NOTICE

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant