skills: force-load adapter-author when creating a command - #404
Open
ayushsingh82 wants to merge 1 commit into
Open
skills: force-load adapter-author when creating a command#404ayushsingh82 wants to merge 1 commit into
ayushsingh82 wants to merge 1 commit into
Conversation
webcmd-usage force-loaded webcmd-browser for raw browser work but had no equivalent for authoring. Agents that discovered browser init on their own then skipped the durable authoring surfaces: they hand-wrote notes next to the adapter instead of using site-memory commands, and invented a sibling *_verify command instead of running webcmd verify / webcmd browser verify. - webcmd-usage now requires loading webcmd-adapter-author before creating, revising, or privately overriding a command, mirroring the existing browser-work requirement. - Added Do-Not lines in both skills against hand-written notes and sibling verify commands. - webcmd-adapter-author now documents that CLI flags map onto args by the declared name (e.g. args['note-id']), not a camelCase alias. Fixes agentrhq#386
Contributor
Author
|
@ankitranjan7 mind taking a look? This closes #386. |
Contributor
🟠 Maintainer review suggested — low confidenceThe automated review could not reach a fully supported conclusion. Limitations
This review is advisory and does not block merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #386.
Problem
webcmd-usageforce-loadswebcmd-browserbefore raw browser work,but had no equivalent requirement for authoring. An agent could
discover
webcmd browser initon its own, write a working command,and never load
webcmd-adapter-author— skipping the durableauthoring surfaces:
going through
webcmd site note/endpoint/field-map.*_verifycommand got invented instead of runningwebcmd verify/webcmd browser verify.Fix
webcmd-usagenow has aREQUIRED SUB-SKILLline forwebcmd-adapter-authorbefore creating, revising, or privatelyoverriding a command, mirroring the existing browser-work
requirement.
Do Notlines in both skills: don't hand-write notesnext to the adapter, don't invent a sibling verify command.
webcmd-adapter-author's Key Conventions now spells out that CLIflags map onto
argsby the declaredname(e.g.args['note-id']),not a Commander camelCase alias — a mistake noted in the source eval
runs.
Skill-doc only change; no runtime/CLI behavior touched.
Test plan
npm run typecheck— clean.npm run test— 447 files / 5757 tests pass.make verify— skill build (skill-src/→skills/) in sync.src/skills.test.tsto assert the new force-load line andanti-pattern text in both skills.