Skip to content

Fix Cloak E2E profile setup - #416

Merged
ankitranjan7 merged 1 commit into
mainfrom
fix/latest-failing-test
Aug 22, 2026
Merged

Fix Cloak E2E profile setup#416
ankitranjan7 merged 1 commit into
mainfrom
fix/latest-failing-test

Conversation

@ankitranjan7

Copy link
Copy Markdown
Contributor

Description

Creates the temporary Cloak profiles used by tests/e2e/cloak-runtime.test.ts before calling session create. Latest main now rejects unknown WEBCMD_PROFILE values with PROFILE_NOT_FOUND, so the E2E setup needs to create its isolated profiles explicitly.

Related issue: none

Type of Change

  • Bug fix
  • New feature
  • New site adapter
  • Documentation
  • Refactor
  • CI / build / tooling

Checklist

  • I ran the checks relevant to this PR
  • I updated tests or docs if needed
  • I included output or screenshots when useful
  • If I edited skill-src/, I ran make build and committed skills/ (not applicable)

Adapter Notes

  • Updated generated or lean docs when command discoverability changed
  • Used positional args for the command's primary subject unless a named flag is clearly better
  • Normalized expected adapter failures to CliError subclasses instead of raw Error

Screenshots / Output

PATH=/Users/ankitranjan/.nvm/versions/node/v22.17.0/bin:$PATH WEBCMD_E2E=0 npx vitest run --project e2e-fixed-port --project e2e tests/e2e/browser-tabs.test.ts tests/e2e/cloak-runtime.test.ts --reporter=verbose
Test Files  2 passed (2)
Tests  4 passed (4)

PATH=/Users/ankitranjan/.nvm/versions/node/v22.17.0/bin:$PATH npm run typecheck
exit 0

PATH=/Users/ankitranjan/.nvm/versions/node/v22.17.0/bin:$PATH npm test
Test Files  448 passed (448)
Tests  5855 passed | 1 skipped (5856)

PATH=/Users/ankitranjan/.nvm/versions/node/v22.17.0/bin:$PATH npm run build
exit 0

git diff --check
exit 0

@github-actions

Copy link
Copy Markdown
Contributor

🟢 No documentation gap found — high confidence

The pull request only changes tests, lockfiles, generated metadata, or dependency metadata.

This review is advisory and does not block merging.

@ankitranjan7
ankitranjan7 merged commit 2ac4708 into main Aug 22, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant