fix: enforce X.509 chain validity and CA constraints - #295
Merged
imran-siddique merged 2 commits intoAug 11, 2026
Conversation
Signed-off-by: Imran Siddique <imran.siddique@opaque.co>
imran-siddique
marked this pull request as ready for review
August 11, 2026 16:01
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harden the shared hardware-attestation certificate-chain verifier beyond signature linkage and root fingerprint pinning.
Every certificate must now be valid at verification time. Every issuer, including the pinned root, must carry
BasicConstraints(ca=True). When an issuer declaresKeyUsage, it must permit certificate signing. A timezone-awareverification_timehook supports deterministic verification and testing.Root cause
verify_cert_chain()previously verified only child signatures/issuer names and the final root fingerprint. A cryptographically linked chain could therefore pass even when a certificate was expired or an intermediate was not authorized to act as a CA.Validation
git diff --check: cleanRegression coverage includes expired leaves, non-CA intermediates, forbidden certificate-signing key usage, and naive verification times.
Documentation