Repository navigation
Report queue add per word, not per branch; make every count agree with its noun - #402
Merged
Merged
Conversation
…h its noun queue add reported each word's branches -- "57 branches -- 0 new, 57 already queued, 23 already solved" -- and closed with "50,931 branches queued" on a run that queued nothing, because that figure counted every branch the words had in the queue, new or not. Each word now gets one line, decided at the word before any branch: already solved, already queued (and where it stays), or queued now at a priority with the branches it has to solve. The summary reports the change made -- the words and branches queued, and at what priorities -- and counts the words left unchanged. Only words being queued take a rung, so the ladder no longer names, or spends rungs on, words that queue nothing. Counts no longer hedge their plural. wordle_ui.count_noun prints a count with the noun, and where needed the verb, that agrees with it, and every "branch(es)", "word(s)" and the like in operator and game output uses it or is rephrased. AGENTS.md states the rule. wordle.py's prompt and its cache-check line change, so BUILD goes to b141. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PpacbZRqT46b4Duhxq5QNQ
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 781da4e927
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…line The "added N branches" count was the word's branches minus those already in the queue, so a branch another opener had already queued was not counted though it was newly attached to this opener's request. add_pending_many now returns, per opener, the branches its request did not own before, read in its own transaction, and queue add reports that. A word whose every response group was filtered out without --pattern got no line. It now says so, and the print requires a line for every skipped word. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PpacbZRqT46b4Duhxq5QNQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
queue addreported at the branch level, and its closing line described state rather than the action. A rerun that queued nothing still ended "50,931 branch(es) queued across 2,000 word(s)". That figure counted every branch the words had in the queue, new or not.BETAS: already solved.(every branch cached)EATEN: already queued at priority 995,004.It stays there. If branches it didn't have were attached, the line adds; added 3 branches to it.CRANE: queued at priority 999,998: 57 branches to solve (23 response groups already solved).…: queued again at priority P; it finished while this ran.(the race Request each opener once: queue add joins an opener's existing request #401 closed)Queued 12 words (1,234 branches) at priorities 999,998 down to 999,943., orQueued no new words.Unchanged: 885 words already queued, left in place; 1,115 words already solved.wordle_ui.count_nounreturns a count with the noun that fits it, and verbs agree where the sentence needs it. Everybranch(es),word(s),owner(s),claim(s)and similar in operator and game output now uses it or is rephrased. That coverserd_search's other commands and logs, the queue's schema messages, the openers report,import_cache, and twowordle.pylines. AGENTS.md gains the rule under Display conventions.wordle.py'sBUILDgoes to b141, since its "Words to test?" prompt and its cache-check line change.🤖 Generated with Claude Code
https://claude.ai/code/session_01PpacbZRqT46b4Duhxq5QNQ