fix: bump transformers floor to 5.15.0 for DeepSeek-V4-Pro config parsing - #1310
debermudez wants to merge 1 commit into
Conversation
Try out this PRQuick install: pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@0ee204746499ed034b0b89aac88ded5d6055da72Recommended with virtual environment (using uv): uv venv --python 3.12 && source .venv/bin/activate
uv pip install --upgrade --force-reinstall git+https://github.com/ai-dynamo/aiperf.git@0ee204746499ed034b0b89aac88ded5d6055da72Last updated for commit: |
…sing transformers>=4.56.0 (currently resolving to 5.6.2) raises an AttributeError while parsing DeepSeek-V4-Pro's config during RoPE param standardization. transformers==5.15.0 handles it natively and also natively registers deepseek_v32, so the config-alias shim added for DeepSeek-V3.2-Exp is now permanently a no-op and has been removed. Signed-off-by: Elias Bermudez <dbermudez@nvidia.com>
b72ebfc to
0ee2047
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (3)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. WalkthroughThe project now requires ChangesDeepSeek-V3.2 shim removal
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The dependency floor and obsolete tokenizer shim are updated together, with the reported reproduction and test suites passing; no actionable merge-blocking risk remains after normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
I'm worried about the compatibility issues this may lead to with customers, especially in light of this Issue: #1278 |
|
I there a better strategy for this? |
|
closing as we have a different approach in the works. |
Summary
transformersdependency floor from>=4.56.0to>=5.15.0— the current floor (resolving to 5.6.2) raisesAttributeError: 'PreTrainedConfig' object has no attribute 'max_position_embeddings'while parsing DeepSeek-V4-Pro's config during RoPE param standardization.deepseek_v32config-alias shim fromtokenizer.py(and its test file): transformers 5.15.0 registersdeepseek_v32natively, so the shim is now a permanent no-op, matching the removal condition documented in its own docstring.docs/reference/tokenizer-auto-detection.mdto drop the now-stale shim documentation.Test plan
aiperf profile --tokenizer deepseek-ai/DeepSeek-V4-Pro ...) — completes cleanly withtransformers==5.15.0, no error.uv run pytest tests/unit/ -n auto— 17999 passed, 93 skipped, 3 xfailed.uv run pytest tests/unit/property/ -n auto— 59 passed (NaN/Inf invariants).pre-commit run --all-filesequivalent on changed files — clean.Summary by CodeRabbit
Documentation
Compatibility
Maintenance