refactor: frontend/test_vllm.py to use shared dynamic ports #5013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keivenchang
changed the title
keivenchang
changed the title
keivenchang
force-pushed
the
keivenchang/DIS-1193__refactor-common-dynamic-ports-part7
branch
from
2fbee30 to
dfc5606
Compare
- Use runtime_services_dynamic_ports + shared ServicePorts/dynamo_dynamic_ports for xdist-safe ports\n- Avoid terminating pytest by default in DynamoFrontendProcess\n- Prevent tokio runtime drop panic during tokenizer/encoding initialization\n- Add per-test pytest timeouts and record suite runtime Signed-off-by: Keiven Chang <[email protected]>
keivenchang
force-pushed
the
keivenchang/DIS-1193__refactor-common-dynamic-ports-part7
branch
from
dfc5606 to
3cded94
Compare
Signed-off-by: Keiven Chang <[email protected]>
Signed-off-by: Keiven Chang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Refactors the frontend vLLM tests to use shared dynamic-port fixtures and the shared
DynamoFrontendProcessimplementation. This improves parallel-safety and reduces flaky behavior from port collisions or overly-broad process cleanup.Details:
tests/frontend/test_vllm.pyto useruntime_services_dynamic_portsandServicePortsfor all frontend/worker URLspytest.mark.timeout(...)annotations based on measured runtimes and record total suite wall time in the test file headertests/conftest.pyviadynamo_dynamic_ports+num_system_ports, usingServicePortsfromtests/utils/port_utils.pyWhere should the reviewer start?
tests/frontend/test_vllm.py
tests/conftest.py
tests/utils/managed_process.py
tests/utils/port_utils.py
lib/parsers/src/reasoning/gpt_oss_parser.rs
Related Issues: (use Closes / Fixes / Resolves / Relates to)
DIS-1193, DIS-1194
/coderabbit profile chill