Skip to content

refactor(proto): split schema by domain#8

Merged
connorcarpenter15 merged 3 commits into
mainfrom
refactor/split-proto-files
Jul 10, 2026
Merged

refactor(proto): split schema by domain#8
connorcarpenter15 merged 3 commits into
mainfrom
refactor/split-proto-files

Conversation

@connorcarpenter15

@connorcarpenter15 connorcarpenter15 commented Jul 10, 2026

Copy link
Copy Markdown
Member

Summary

  • split the openengine.v1 schema into domain-oriented proto files
  • retain one openengine.v1.OpenEngine service and one protobuf package
  • keep openengine.proto as the service entry point
  • add a package README and update documentation and code-generation guidance

Why

The schema had grown to 708 lines, 79 message and enum types, and 14 RPCs across generation, discovery, lifecycle, LoRA, KV, and observability domains. Domain files make the contract easier to navigate and evolve without introducing new protobuf packages or services.

Impact

All message, enum, service, and RPC descriptors are unchanged. Generated source now spans domain-specific modules, so consumers must compile every .proto file under proto/openengine/v1/ rather than compiling only openengine.proto.

Validation

  • buf build
  • buf lint
  • buf format --diff --exit-code
  • descriptor equivalence against main: 80 top-level symbols matched
  • Python binding generation and OpenEngineStub import: 20 generated modules
  • markdownlint-cli2 0.23.0: 0 errors
  • Lychee 0.24.2: 67 links checked, 0 errors

Signed-off-by: Connor Carpenter <connorc@nvidia.com>
Signed-off-by: Connor Carpenter <connorc@nvidia.com>
Signed-off-by: Connor Carpenter <connorc@nvidia.com>
@connorcarpenter15 connorcarpenter15 marked this pull request as ready for review July 10, 2026 18:25
@connorcarpenter15 connorcarpenter15 merged commit 55f4101 into main Jul 10, 2026
5 checks passed
@connorcarpenter15 connorcarpenter15 deleted the refactor/split-proto-files branch July 10, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant