Skip to content

task(CI): make ketryx report job run only on main #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
na66im wants to merge 1 commit into from
Closed

task(CI): make ketryx report job run only on main #392

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci-cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ jobs:
ketryx_report_and_check:
needs: [get-commit-message, lint, audit, test, codeql]
if: |
github.ref == 'refs/heads/main' &&
Copy link

@sentry sentry bot Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The new condition on ketryx_report_and_check will cause it to be skipped on tag pushes, which in turn will skip the package_publish and docker_publish jobs.
Severity: CRITICAL

Suggested Fix

The condition for the ketryx_report_and_check job should be updated to also run on tag pushes. A possible fix is to change the condition to github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags/v') to allow the job to run for both main branch pushes and version tag pushes.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: .github/workflows/ci-cd.yml#L136

Potential issue: The `ketryx_report_and_check` job's new condition `github.ref ==
'refs/heads/main'` restricts it to run only on pushes to the `main` branch. However, the
`package_publish` and `docker_publish` jobs, which are triggered by version tags (e.g.,
`v1.2.3`), depend on `ketryx_report_and_check`. When a version tag is pushed,
`ketryx_report_and_check` will be skipped because the ref does not match `main`. Since
the dependent publish jobs do not use an `always()` condition, they will also be
skipped, silently breaking the release process and preventing new packages and Docker
images from being published.

Did we get this right? 👍 / 👎 to inform future reviews.

github.actor != 'dependabot[bot]' &&
(!contains(needs.get-commit-message.outputs.commit_message, 'skip:ci')) &&
(!contains(needs.get-commit-message.outputs.commit_message, 'build:native:only')) &&
Expand Down
Loading