Fix on client_credentials no working#133
Open
danirolopes wants to merge 2 commits intoairbytehq:mainfrom
Open
Conversation
This was referenced Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The use of urljoin on the do_token_request was creating a bug for the base configuration.
When the self.base_url was the default "https://api.airbyte.com/v1" and credentials was the default "/applications/token", it did not work as expected
Expected result: "https://api.airbyte.com/v1/applications/token"
Real result: "https://api.airbyte.com/applications/token"
So the client auth did not work. Did a simple fix, since changing the self.base_url to "https://api.airbyte.com/v1/" broke other things
Versions used:
Python 3.10.10
urllib 2.5.0
airbyte sdk 0.53.0
Running on MacOS 12.6.6