Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
164 changes: 164 additions & 0 deletions pollution_prediction/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,164 @@
### Python template
# Byte-compiled / optimized / DLL files
__pycache__/
*.py[cod]
*$py.class

# C extensions
*.so

# Distribution / packaging
.Python
build/
develop-eggs/
dist/
downloads/
eggs/
.eggs/
lib/
lib64/
parts/
sdist/
var/
wheels/
share/python-wheels/
*.egg-info/
.installed.cfg
*.egg
MANIFEST

# PyInstaller
# Usually these files are written by a python script from a template
# before PyInstaller builds the exe, so as to inject date/other infos into it.
*.manifest
*.spec

# Installer logs
pip-log.txt
pip-delete-this-directory.txt

# Unit test / coverage reports
htmlcov/
.tox/
.nox/
.coverage
.coverage.*
.cache
nosetests.xml
coverage.xml
*.cover
*.py,cover
.hypothesis/
.pytest_cache/
cover/

# Translations
*.mo
*.pot

# Django stuff:
*.log
local_settings.py
db.sqlite3
db.sqlite3-journal

# Flask stuff:
instance/
.webassets-cache

# Scrapy stuff:
.scrapy

# Sphinx documentation
docs/_build/

# PyBuilder
.pybuilder/
target/

# Jupyter Notebook
.ipynb_checkpoints

# IPython
profile_default/
ipython_config.py

# pyenv
# For a library or package, you might want to ignore these files since the code is
# intended to run in multiple environments; otherwise, check them in:
# .python-version

# pipenv
# According to pypa/pipenv#598, it is recommended to include Pipfile.lock in version control.
# However, in case of collaboration, if having platform-specific dependencies or dependencies
# having no cross-platform support, pipenv may install dependencies that don't work, or not
# install all needed dependencies.
#Pipfile.lock

# poetry
# Similar to Pipfile.lock, it is generally recommended to include poetry.lock in version control.
# This is especially recommended for binary packages to ensure reproducibility, and is more
# commonly ignored for libraries.
# https://python-poetry.org/docs/basic-usage/#commit-your-poetrylock-file-to-version-control
#poetry.lock

# pdm
# Similar to Pipfile.lock, it is generally recommended to include pdm.lock in version control.
#pdm.lock
# pdm stores project-wide configurations in .pdm.toml, but it is recommended to not include it
# in version control.
# https://pdm.fming.dev/latest/usage/project/#working-with-version-control
.pdm.toml
.pdm-python
.pdm-build/

# PEP 582; used by e.g. github.com/David-OConnor/pyflow and github.com/pdm-project/pdm
__pypackages__/

# Celery stuff
celerybeat-schedule
celerybeat.pid

# SageMath parsed files
*.sage.py

# Environments
.env
.venv
env/
venv/
ENV/
env.bak/
venv.bak/

# Spyder project settings
.spyderproject
.spyproject

# Rope project settings
.ropeproject

# mkdocs documentation
/site

# mypy
.mypy_cache/
.dmypy.json
dmypy.json

# Pyre type checker
.pyre/

# pytype static type analyzer
.pytype/

# Cython debug symbols
cython_debug/

# PyCharm
# JetBrains specific template is maintained in a separate JetBrains.gitignore that can
# be found at https://github.com/github/gitignore/blob/main/Global/JetBrains.gitignore
# and can be added to the global gitignore or merged into this file. For a more nuclear
# option (not recommended) you can uncomment the following to ignore the entire idea folder.
.idea/

31 changes: 31 additions & 0 deletions pollution_prediction/app.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
from flask import Flask, make_response
from flask_cors import CORS
from controllers.controllers import controller_bp

app = Flask(__name__)
CORS(app)
app.register_blueprint(controller_bp, url_prefix="/api/v2/spatial")


# Add custom CORS header
@app.after_request
def add_cors_headers(response):
response.headers[
"Access-Control-Allow-Origin"
] = "*" # You can specify specific origins instead of '*'
response.headers[
"Access-Control-Allow-Headers"
] = "Content-Type, Authorization, X-Requested-With, X-Auth-Token"
response.headers["Access-Control-Allow-Methods"] = "GET,PUT,POST,DELETE,OPTION"
response.headers["Access-Control-Allow-Credentials"] = "true"
return response
Comment on lines +11 to +21
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Security: Restrict CORS origin when allowing credentials.

There are two security concerns with the current CORS configuration:

  1. Using wildcard (*) for Access-Control-Allow-Origin in production is not recommended
  2. Browsers will reject requests when credentials are allowed with a wildcard origin

Consider using environment variables to configure allowed origins:

-    response.headers["Access-Control-Allow-Origin"] = "*"
+    allowed_origins = os.getenv('ALLOWED_ORIGINS', '').split(',')
+    origin = request.headers.get('Origin')
+    if origin in allowed_origins:
+        response.headers["Access-Control-Allow-Origin"] = origin

Don't forget to import os and request:

from flask import Flask, request
import os



# Define your own blueprints with business logic
@app.route("/test", methods=["GET"])
def test():
return "Test success"


if __name__ == "__main__":
app.run()
Comment on lines +30 to +31
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Configure app.run() for development and use WSGI server for production.

The current setup lacks proper configuration for different environments.

 if __name__ == "__main__":
-    app.run()
+    env = os.getenv("FLASK_ENV", "development")
+    if env == "development":
+        app.run(
+            host=os.getenv("FLASK_HOST", "0.0.0.0"),
+            port=int(os.getenv("FLASK_PORT", "5000")),
+            debug=True
+        )
+    else:
+        # Use gunicorn or other WSGI server in production
+        app.run(debug=False)

Committable suggestion skipped: line range outside the PR's diff.

20 changes: 20 additions & 0 deletions pollution_prediction/controllers/controllers.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# controller/controller.py
from flask import Blueprint, request, jsonify

from views.pollutant_views import PollutantApis


controller_bp = Blueprint("controller", __name__)


@controller_bp.route('/upload-image', methods=['POST'])
def upload_image_for_prediction():
return PollutantApis.upload_image()

@controller_bp.route('/get-data-by-confidence', methods=['GET'])
def get_data_by_confidence():
return PollutantApis.get_data_by_confidence()

@controller_bp.route('/get-all-data', methods=['GET'])
def get_all_data():
return PollutantApis.get_all_data()
Loading