Skip to content

Run Github actions on releases#92

Open
djjudas21 wants to merge 1 commit into
akhilrex:masterfrom
djjudas21:ci
Open

Run Github actions on releases#92
djjudas21 wants to merge 1 commit into
akhilrex:masterfrom
djjudas21:ci

Conversation

@djjudas21

Copy link
Copy Markdown
  • Run the release pipeline only on tags/releases, and use the tag on the Docker image too, instead of hard-coding 1.0.0
  • Add a simple CI pipeline on every commit to run basic go and npm tests. Please note the npm tests are currently failing, but I think this is a problem with the code rather than the pipeline.

Hope this helps improve the devops on this project 😄
Part of #91

Run release pipeline on tags
@djjudas21

Copy link
Copy Markdown
Author

Hey, is there any progress on this issue? I see you're still deploying a hard-coded tag of 1.0.0 to Docker Hub https://hub.docker.com/r/akhilrex/hammond/tags

It would really help me maintain the Helm chart if you would consider using semver releases 😄

@djjudas21

Copy link
Copy Markdown
Author

Hey @akhilrex, please would you consider merging this? It would improve the project workflow so much, and it will make my Helm chart more reliable, which will get more users using it.

@AlfHou

AlfHou commented Nov 19, 2022

Copy link
Copy Markdown
Contributor

@djjudas21 I think we might need to consider forking this project. I think the project would really benefit of more people being able to review and merge changes. Feel free to upstream the changes to my fork and I'll pull them in.

@djjudas21

Copy link
Copy Markdown
Author

Thanks @AlfHou. I've submitted AlfHou#1 against your fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants