-
Notifications
You must be signed in to change notification settings - Fork 26
Add Plot loss #939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Plot loss #939
Conversation
|
Thank you for adding this @TheCSGuy25, it looks great! The only thing that needs fixing is the pre-commit and then it's good to merge. Let us know if you need any help with this. |
6054aab to
2afe318
Compare
|
Hey @radka-j I will change the test and exceptions as suggested by the workflow. I have a question related to message that was shown as a part of it I looked at the |
|
@TheCSGuy25 thank you for checking There are two options:
if not hasattr(model, "loss_history"):
msg = "Emulator does not have a Loss history"
raise AttributeError(msg)
history = model.loss_historyThis is essentially what you implemented but should (I think) satisfy the pre-commit check. Let me know if you have any questions and/or anything else comes up. |
|
@radka-j Hello ! So it passed the pre-commit, but now it show's an issue with
as well as Do let me know how i can help to resolve this. (Note: I have synced the fork and branches with the main as well) |
|
@TheCSGuy25 this all looks great! The bug had something to do with the docs and is not related to this PR. Thank you again for implementing this and for your patience with getting the CI to pass :) |
Added the Plot Loss Method, that accepts an emulator along with optional plot title and figure size as arguments and will plot the loss with respect to epochs and will raise an
AttributeErrorif the emulator has no loss_history attribute.