Skip to content

Make loss_history instance variable (not class variable) #940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radka-j merged 1 commit into from
Nov 27, 2025
Merged

Make loss_history instance variable (not class variable) #940

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions autoemulate/emulators/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import random
from abc import ABC, abstractmethod
from typing import ClassVar

import numpy as np
import torch
Expand Down Expand Up @@ -545,7 +544,6 @@ class PyTorchBackend(nn.Module, Emulator):
batch_size: int = 16
shuffle: bool = True
epochs: int = 10
loss_history: ClassVar[list[float]] = []
verbose: bool = False
loss_fn: nn.Module = nn.MSELoss()
optimizer_cls: type[optim.Optimizer] = optim.Adam
Expand All @@ -570,6 +568,8 @@ def _fit(self, x: TensorLike, y: TensorLike):
y: OutputLike or None
Target values (not needed if x is a DataLoader).
"""
self.loss_history: list[float] = []

self.train() # Set model to training mode

# Convert input to DataLoader if not already
Expand Down