fix: retry file upload on 404 for network propagation delays#274
Closed
odesenfans wants to merge 1 commit into
Closed
fix: retry file upload on 404 for network propagation delays#274odesenfans wants to merge 1 commit into
odesenfans wants to merge 1 commit into
Conversation
CCNs now return 404 after 30s if unable to stat a file on IPFS (instead of 50x after 5s). Since the SDK knows the file was just uploaded (it just did), retry with exponential backoff (1s, 2s, 4s) to handle propagation delays.
|
Failed to retrieve llama text: POST 503: 503 Service UnavailableNo server is available to handle this request. |
Contributor
Author
|
This doesn't seem to be actually needed. The server is the one who should retry and return a 500 if it fails to stat the file, actually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CCNs now return 404 after 30s if unable to stat a file on IPFS (instead of 50x after 5s). Since the SDK knows the file was just uploaded (it just did), retry with exponential backoff (1s, 2s, 4s) to handle propagation delays.