feat: add cursor-based pagination for messages and posts#282
Merged
Conversation
Add get_messages_cursor() and get_posts_cursor() methods that use cursor-based pagination (faster, no COUNT query). Update iterators to use cursor mode by default, eliminating duplicate results.
|
Failed to retrieve llama text: POST 502: Bad Gateway |
Add stub implementations for get_posts_cursor and get_messages_cursor to satisfy the abstract class contract.
amalcaraz
added a commit
to aleph-im/aleph-nodestatus
that referenced
this pull request
May 20, 2026
Offset pagination on /api/v0/messages.json was hitting aiohttp's 5-min timeout before the first page returned for AGGREGATE+date-filtered queries over multi-week windows. aleph-im/aleph-sdk-python#282 added cursor-based pagination (`get_messages_cursor` / `get_posts_cursor`) in 2.3.2+ — server-side it scans by sort key, not row offset, so deep pages don't slow down. Adopt it. Dep cascade required by aleph-sdk-python>=2.3.2: - python: 3.9-slim → 3.12-slim (3.9 EOL'd 2025-10; SDK 2.3.2+ requires >=3.10) - aleph-sdk-python: 1.4.0 → 2.3.3 - aleph-message: 0.5 → 1.1 - aleph-superfluid: 0.2 → 0.3 - pydantic: 1.10 → 2.13 (+ pydantic-settings 2.x for BaseSettings, now a separate pkg) - web3: 6.3 → 7.16 - eth-account: ≥0.13 Migration touches: - settings.py: BaseSettings import path, `@field_validator` decorator, `SettingsConfigDict` for env_file, type annotations on two previously bare fields. - erc20.py, sablier.py: drop dead imports of `geth_poa_middleware` and `local_filter_middleware` (web3 7 removed both; neither was used). - ethereum.py, payment_processor.py: eth-account 0.13 renamed `signed.rawTransaction` → `signed.raw_transaction`. - credit_distribution.py: `_LoggingAlephHttpClient` now overrides `get_messages_cursor` and `get_posts_cursor` for per-cursor progress logs + timeout-aware error. `_iter_messages_dedup` walks `next_cursor` instead of `get_messages_iterator`; the JSONL cache stores `model_dump(mode="json")` output for json-safe round-trip. `get_latest_successful_credit_distribution` walks posts via `get_posts_cursor` too. 43/43 tests pass on the new stack. Docker image rebuilt and inspected to confirm aleph-sdk-python 2.3.3 + pydantic 2.13 + web3 7.16 install clean under python:3.12-slim.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_messages_cursor()andget_posts_cursor()methods using cursor-based pagination (no COUNT query, faster for large result sets)CursorPaginationResponse,CursorPostsResponse, andCursorMessagesResponseresponse modelsget_messages_iterator()andget_posts_iterator()to use cursor-based pagination, eliminating duplicate resultssortBy=tx-timewith cursor mode, caps page size at 200Test plan
get_messages_cursor()andget_posts_cursor()return correct cursor-paginated responsesValueErroris raised when usingsortBy=tx-timewith cursor methodsnext_cursor=Nonecorrectly terminates iteration