Skip to content
This repository was archived by the owner on Jan 31, 2022. It is now read-only.
This repository was archived by the owner on Jan 31, 2022. It is now read-only.

MirroredIndex:getObjectAsync is crashing #564

Description

@robertmogos

Do you want to request a feature or report a bug?
Bug

Bug: What is the current behavior?

public Request getObjectAsync(final @NonNull String objectID, final @Nullable Collection<String> attributesToRetrieve, @Nullable RequestOptions requestOptions, @NonNull CompletionHandler completionHandler

In the MirroredIndex:getObjectAsync we allow attributesToRetrieve to be nullable.
If the index is mirrored we return a new OnlineOfflineGetObjectRequest.
In the constructor we are creating a new ArrayList from attributesToRetrieve.
When the later is null, it will result in a crash.

Bug: What is the expected behavior?

Not crashing would be pretty sweet.

Bug: Which versions?

Latest

Bug: How to reproduce ?

 mirroredIndex.getObjectAsync("my-awesome-id", new CompletionHandler() {
            @Override
            public void requestCompleted(JSONObject jsonObject, AlgoliaException e) {
                //...
            }
});

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions