feat: add auto_indexing param to register decorator function - #305
Open
KarimTayie wants to merge 3 commits into
Open
feat: add auto_indexing param to register decorator function#305KarimTayie wants to merge 3 commits into
KarimTayie wants to merge 3 commits into
Conversation
tkrugg
requested changes
Jan 26, 2021
Contributor
There was a problem hiding this comment.
Hi @KarimTayie, thank you for your contribution!
I think your PR might be addressing #277, can you confirm?
It's also addressing: #276.
The change looks great. Please would you be able to add some tests in tests/test_decorators.py and tests/test_engine.py to verify this is working as expected?
tkrugg
requested review from
chloelbn,
clemfromspace and
tkrugg
and removed request for
tkrugg
March 9, 2021 14:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change
Added auto_indexing parameter to register decorator function with None as a default value
for backward compatibility.
if a boolean value has been passed to register decorator or register function for auto_indexing parameter
prioritize it over the value from the settings.
What problem is this fixing?
With this change, I can enable/disable auto_indexing on any specific sub-class of AlgoliaIndex with register decorator.
Now I can make the auto_indexing setting=True but when I call register function or decorator with auto_indexing=False
it will take it and prioritize it over the setting value.