feat(specs): remove migratedAbTestID from abtesting-v3 - #6883
Open
cdhawke wants to merge 2 commits into
Open
Conversation
Contributor
💥 Breaking changes detected !!Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging. ✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
cdhawke
force-pushed
the
chore/deprecate-migrated-abtest-id
branch
from
August 11, 2026 21:36
3777f61 to
5aa0df7
Compare
cdhawke
changed the title
BREAKING CHANGE: the migratedAbTestID field is removed from the ABTest response schema, so it disappears from all generated clients. The field exists only for the one-off US->EU A/B test region migration, which finished in 2024. Nothing has been written for 2.4 years: the newest row carrying a value on abtests-prod-europe-west3 was created 2024-03-05, all 1,408 of them are in a terminal state, and zero rows carry it in us-east1. Nothing reads it either. The dashboard's last reference went in AlgoliaWeb#29783, and the API stops emitting it in algolia/go#26972. Order matters: ABTest is additionalProperties: false, so removing the property while the API still sends it would make this spec declare those responses invalid. algolia/go#26972 must be merged and deployed first. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
cdhawke
force-pushed
the
chore/deprecate-migrated-abtest-id
branch
from
August 12, 2026 00:15
5aa0df7 to
3876d9f
Compare
cdhawke
changed the title
cdhawke
marked this pull request as ready for review
August 20, 2026 19:31
Niamsy
approved these changes
Aug 21, 2026
Contributor
Author
|
@Fluf22 @MarioAlexandruDan could you have a look at this when you get some time? 🙏🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: OPTIM-2329
algolia/go#26972 is merged and deployed
Breaking: removes
migratedAbTestIDfrom theabtesting-v3ABTestschema, so it disappears from all eight generated clients.The field exists only for the one-off US→EU A/B test region migration, which finished in 2024. Measured on
abtests-prod-europe-west3:created_atactiveabtests-prod-us-east1Nothing has been written for 2.4 years, and nothing reads it: the dashboard's last reference went in AlgoliaWeb#29783, and the API stops emitting it in algolia/go#26972.
Changes included:
migratedAbTestIDproperty fromABTestand theMigratedABTestIdschema it referenced.Deliberately a removal rather than a deprecation. A deprecation marker promises removal, and there is no migration path to signal — the field has no successor and no remaining consumer, so the notice would only add noise to eight clients' typedefs.
🧪 Test
Green CI. Spec-only, so no generated code is included, per the CI note that generated code is pushed at the end of the run.
Locally verified with
yaml.safe_load: theMigratedABTestIdschema and themigratedAbTestIDproperty are both gone, no dangling$refremains,ABTest.requiredis unchanged, and the property count drops from 10 to 9.Needs a release note calling out the removal.