Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .clang-tidy
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ Checks: >
modernize-use-nullptr,
modernize-use-override,
WarningsAsErrors: "*"
HeaderFilterRegex: "^(src|tests|tools)/(?!db/sqlengine/antlr/gen/).*"
HeaderFilterRegex: "^(src|tests|tools)/(?!db/sqlengine/antlr/gen/|db/index/column/fts_column/gen/|include/zvec/ailego/encoding/json/mod_json\\.h).*"
FormatStyle: none
SystemHeaders: false
4 changes: 4 additions & 0 deletions .github/workflows/clang_tidy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,13 @@ jobs:
**/*.cc
**/*.cpp
**/*.cxx
**/*.h
**/*.hpp
files_ignore: |
thirdparty/**
build/**
src/db/sqlengine/antlr/gen/**
src/db/index/column/fts_column/gen/**

- name: No C/C++ files changed - skip
if: steps.changed_files.outputs.any_changed != 'true'
Expand Down
8 changes: 4 additions & 4 deletions src/include/zvec/core/framework/index_holder.h
Original file line number Diff line number Diff line change
Expand Up @@ -99,13 +99,13 @@ struct IndexHybridHolder : public IndexHolder {
~Iterator(void) override {}

//! Retrieve pointer of data
virtual const void *data(void) const = 0;
const void *data(void) const override = 0;

//! Test if the iterator is valid
virtual bool is_valid(void) const = 0;
bool is_valid(void) const override = 0;

//! Retrieve primary key
virtual uint64_t key(void) const = 0;
uint64_t key(void) const override = 0;

//! Retrieve sparse count
virtual uint32_t sparse_count() const = 0;
Expand All @@ -117,7 +117,7 @@ struct IndexHybridHolder : public IndexHolder {
virtual const void *sparse_data() const = 0;

//! Next iterator
virtual void next(void) = 0;
void next(void) override = 0;
};

//! Destructor
Expand Down
Loading